Change X509-SVID subject values #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As outlined in spiffe#3341, this change behavior that controls the subject of X509-SVIDs signed by the SPIRE Server CA. Instead of a fixed subject (i.e. "O=SPIRE,C=US"), the subject now inherits the subject of the signing CA (sans the CommonName). It also adds a UniqueID attribute to the subject. The Unique ID is per SPIFFE ID. This brings us into RFC 5280 conformance. The new behavior can be disabled with an immediately deprecated flag, "omit_x509svid_uid". This flag will be removed in a future release. Fixes: spiffe#3341 Signed-off-by: Andrew Harding <[email protected]>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
MarcosDY
reviewed
Aug 22, 2022
Signed-off-by: Andrew Harding <[email protected]>
Signed-off-by: Andrew Harding <[email protected]>
Signed-off-by: Andrew Harding <[email protected]>
MarcosDY
previously approved these changes
Aug 26, 2022
cmd/spire-server/cli/run/run.go
Outdated
| @@ -82,6 +82,7 @@ type serverConfig struct { | |||
| LogFile string `hcl:"log_file"` | |||
| LogLevel string `hcl:"log_level"` | |||
| LogFormat string `hcl:"log_format"` | |||
| OmitX509SVIDUID *bool `hcl:"omit_x509svid_uid"` | |||
There was a problem hiding this comment.
NIT: Can you add a // DEPRECATED: remove this migration in 1.5.0? (or the minor version we can remove it)
here or in pkg/server/config.go
Signed-off-by: Andrew Harding <[email protected]>
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
* Change X509-SVID subject values As outlined in spiffe#3341, this change behavior that controls the subject of X509-SVIDs signed by the SPIRE Server CA. Instead of a fixed subject (i.e. "O=SPIRE,C=US"), the subject now also has a UniqueID attribute. The Unique ID is per SPIFFE ID. This brings us into RFC 5280 conformance. The new behavior can be disabled with an immediately deprecated flag, "omit_x509svid_uid". This flag will be removed in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #3341, this change behavior that controls the subject of X509-SVIDs signed by the SPIRE Server CA.
Instead of a fixed subject (i.e. "O=SPIRE,C=US"), the subject now
inherits the subject of the signing CA (sans the CommonName). It also addsalso has a UniqueID attributeto the subject. The Unique ID is per SPIFFEID. This brings us into RFC 5280 conformance.The new behavior can be disabled with an immediately deprecated flag, "omit_x509svid_uid". This flag will be removed in a future release.
Edit: backed out the subject inheritance code while we discuss that behavior more fully