Update cliprinter default flag name #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermocc
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
3 tasks
azdagron
reviewed
Oct 25, 2022
Signed-off-by: Guilherme Carvalho <[email protected]>
guilhermocc
force-pushed
the
update-cliprinter-default-flag
branch
from
2772bfe to
c524723
Compare
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Guilherme Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guilherme Carvalho [email protected]
Pull Request check list
Affected functionality
spire-agent fetch jwt
-formatflagDescription of change
Update default flag name for the cliprinter from
-formatto-output. This decisions was taken in the contributor sync after we saw that-formatflag conflicts with the-formatflag that is already being used in spire-server bundle commands.Which issue this PR fixes
Ongoing work for #1354