-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename directory in Tornjak Backend container #463
Conversation
Signed-off-by: Vanessa de Jesus Silva <[email protected]>
… script Signed-off-by: Vanessa de Jesus Silva <[email protected]>
Signed-off-by: Vanessa de Jesus Silva <[email protected]>
2dca138
to
a0d66bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution! I left a couple comments on the documentation - some of the commands you changed in the quickstart should be left alone because they are commands for a different container that DOES use the /opt/spire
directory
Have you been able to build/test these changes?
a0d66bf
to
6c09aa9
Compare
That's fair! the backend documentation for testing an image does seem missing. To get started, I'm curious if you are able to run the quickstart? This has instructions for running tornjak locally. Once you are able to run it as is, you would be able to update the image in Definitely ask questions if any! I might try to update that documentation soon |
Thank you, Maia. 😄 ![]() That is what I've added in the ![]() ![]() If possible, help me identify the issue. In parallel, I am trying to do other tests in a relentless quest to make this happen. 😄 |
Thanks for the detailed debug info! The local minikube cluster automatically attempts to pull from DockerHub. So when you specified the image in the yaml as There's two possible remedies:
Let me know if this helps! If not, definitely show the outputs of |
Thank you, Maia! It completely helped me. So now I can run the spire server, along with the tornjak backend (with the changes), and its frontend. ![]() ![]() ![]() In complement, I tested with the non-ubi image which also seem to work fine. ![]() Both UBI and non-UBI images were published on https://hub.docker.com/r/vjesu5/tornjak-backend-ubi and https://hub.docker.com/r/vjesu5/tornjak-backend respectively. I've just tested this end-to-end by navigating through the UI application. I'm unsure how effective the test was to ensure that my changes (path renames) didn't break the application behavior. If you have any additional concerns or backend prints you may require, please let me know. This Pull Request description was updated based on what was changed in fact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you very much for the contribution!
* refactor: updates the tornjak directory for backend dockerfiles Signed-off-by: Vanessa de Jesus Silva <[email protected]> * refactor: updates the tornjak directory references for backend runner script Signed-off-by: Vanessa de Jesus Silva <[email protected]> * refactor: updates the tornjak directory references in examples/ dir Signed-off-by: Vanessa de Jesus Silva <[email protected]> --------- Signed-off-by: Vanessa de Jesus Silva <[email protected]>
* refactor: updates the tornjak directory for backend dockerfiles Signed-off-by: Vanessa de Jesus Silva <[email protected]> * refactor: updates the tornjak directory references for backend runner script Signed-off-by: Vanessa de Jesus Silva <[email protected]> * refactor: updates the tornjak directory references in examples/ dir Signed-off-by: Vanessa de Jesus Silva <[email protected]> --------- Signed-off-by: Vanessa de Jesus Silva Sarmento <[email protected]>
Changes proposed
This PR includes renaming the directory Tornjak from
/opt/spire
to/opt/tornjak
mentioned in the opened issue #259 for:examples/
directory.