Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KHR_mesh_quantization #2

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Add KHR_mesh_quantization #2

merged 1 commit into from
Oct 11, 2022

Conversation

Eearslya
Copy link
Contributor

Really all that's needed is to let fastgltf know about the extension.

The only changes it brings is allowing more types in accessors for mesh data.

spnda
spnda approved these changes Oct 11, 2022
View reviewed changes
Copy link
Owner

@spnda spnda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan on adding a validate function to the glTF class that validates the parsed data more exactly as currently a lot of things are just taken as given (e.g. indices). That would then require support for the extension, but for now yeah looks good.

@spnda spnda merged commit 364394a into spnda:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spnda spnda spnda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eearslya @spnda