MultiRabbitListenerAnnotationBeanPostProcessor resolveMultiRabbitAdminName

[ngocnhan-tran1996]

issue #2809

Condition in MultiRabbitListenerAnnotationBeanPostProcessor#resolveMultiRabbitAdminName

1. Get RabbitListener#admin if it's not blank else
2. Get RabbitListener#containerFactory return RabbitListener#containerFactory + -admin if it's not blank else
3. Get RabbitListenerConfigUtils#RABBIT_ADMIN_BEAN_NAME

in case 2, I think just get bean name from SpEL #{@...} and concate string, no need call super#resolveExpressionAsString. Wherther the given name is valid or not, function chain in class RabbitListenerAnnotationBeanPostProcessor will attempt to create RabbitAmin with it.

Please give me more advice if I miss something

[artembilan]

Thank you for proposed fix!
Unfortunately we cannot go via simple expression parsing where it would simply be just a plain bean name without an expression wrapping. The point of the expression is really let to do more complex logic for that resolution.

See my comment in the respective issue to make it more robust: #2809 (comment)

[artembilan]

And your name to the @author section of all the affected classes.

[artembilan]

Oh! I see now what you mean:

 EnableRabbitTests > sampleConfiguration() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "rabbitListenerContainerFactory"
     but was: null
        at app//org.springframework.amqp.rabbit.annotation.AbstractRabbitAnnotationDrivenTests.testSampleConfiguration(AbstractRabbitAnnotationDrivenTests.java:91)
        at app//org.springframework.amqp.rabbit.annotation.EnableRabbitTests.sampleConfiguration(EnableRabbitTests.java:71)

Apparently those tests are based on some test entity.
So, yeah: we have to have these new methods implemented in that RabbitListenerContainerTestFactory as well.

Why do you push commits for every line of code you change?
Why just don't combine all the requested changes and send a single commit with a proper message?

Thanks

[ngocnhan-tran1996]

And your name to the @author section of all the affected classes.

Oh! I see now what you mean:

 EnableRabbitTests > sampleConfiguration() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "rabbitListenerContainerFactory"
     but was: null
        at app//org.springframework.amqp.rabbit.annotation.AbstractRabbitAnnotationDrivenTests.testSampleConfiguration(AbstractRabbitAnnotationDrivenTests.java:91)
        at app//org.springframework.amqp.rabbit.annotation.EnableRabbitTests.sampleConfiguration(EnableRabbitTests.java:71)

Apparently those tests are based on some test entity. So, yeah: we have to have these new methods implemented in that RabbitListenerContainerTestFactory as well.

Why do you push commits for every line of code you change? Why just don't combine all the requested changes and send a single commit with a proper message?

Thanks

Sorry, my network is so lag. After reloading github page, I have seen your newest comment
I bring it back and test is passed

[artembilan]

@ngocnhan-tran1996 ,

thank you for contribution; looking forward for more!

[ngocnhan-tran1996]

@artembilan

Thanks for your review. I have learn a lot.