PR: Remove pexpect from windows requirements #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
May 31, 2018
README.rst
Outdated
| 4. `Coloredlogs <https://github.com/xolox/python-coloredlogs>`_ | ||
| 5. `xterm.js <https://github.com/sourcelair/xterm.js>`_ | ||
| 3. `Coloredlogs <https://github.com/xolox/python-coloredlogs>`_ | ||
| 4. `xterm.js <https://github.com/sourcelair/xterm.js>`_ |
There was a problem hiding this comment.
Please change this:
- Mention that
pexpectis needed on Linux and macOS. - Add
pywinptyhere, saying also that's only needed for Windows.
|
You also need to remove |
ccordoba12
reviewed
May 31, 2018
README.rst
Outdated
| 3. `Coloredlogs <https://github.com/xolox/python-coloredlogs>`_ | ||
| 4. `xterm.js <https://github.com/sourcelair/xterm.js>`_ | ||
| 3. `Pexpect <https://github.com/pexpect/pexpect>`_ (*nix Systems) | ||
| 4. `pywinpty <https://github.com/spyder-ide/pywinpty>` (Windows Systems) |
There was a problem hiding this comment.
There's a missing _ at the end ;-p:
..spyder-ide/pywinpty>_`
ccordoba12
reviewed
May 31, 2018
README.rst
Outdated
| @@ -97,7 +97,8 @@ This project depends on | |||
|
|
|||
| 1. `Spyder <https://github.com/spyder-ide/spyder>`_ | |||
| 2. `Tornado <https://github.com/tornadoweb/tornado>`_ | |||
| 3. `Pexpect <https://github.com/pexpect/pexpect>`_ | |||
| 3. `Pexpect <https://github.com/pexpect/pexpect>`_ (*nix Systems) | |||
| 4. `pywinpty <https://github.com/spyder-ide/pywinpty>` (Windows Systems) | |||
There was a problem hiding this comment.
It seems my last comment was not registered correctly: please add a missing _ at the end here, i.e.
pywinpty <https://github.com/spyder-ide/pywinpty>`_ (Windows Systems)
ccordoba12
approved these changes
May 31, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136