Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update SpyderPluginWidget import #150

Merged
merged 2 commits into from
Jun 4, 2019
Merged

PR: Update SpyderPluginWidget import #150

merged 2 commits into from
Jun 4, 2019

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Jun 2, 2019

Fixes #149

ccordoba12
ccordoba12 reviewed Jun 2, 2019
View reviewed changes
spyder_terminal/terminalplugin.py Outdated
@@ -20,7 +20,7 @@
from qtpy.QtCore import Qt, Signal, QTimer, Slot
from qtpy.QtGui import QKeySequence

from spyder.plugins import SpyderPluginWidget
from spyder.api.plugins import SpyderPluginWidget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make things to work with Spyder 3 and 4, like this

https://github.com/spyder-ide/spyder-notebook/blob/d4530aef67bec00cc98b294fc3694540636c7207/spyder_notebook/notebookplugin.py#L41-L46

@andfoy andfoy merged commit 7be9246 into spyder-ide:master Jun 4, 2019
@andfoy andfoy deleted the new_api_reference branch June 4, 2019 03:57
@ccordoba12 ccordoba12 added this to the v0.3.0 milestone Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Spyder-terminal is not starting on spyder 4 beta 2
2 participants
@andfoy @ccordoba12