Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix styling issues for UI consistency #166

Merged
merged 3 commits into from
Jan 23, 2020

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Jan 23, 2020

These changes allow the plugin to have a consistent UI with the rest of spyder. The buttons and the menu have the same options.

Fixes #161

image

@goanpeca
Copy link
Member

@steff456 could you add a little internal padding to the console so that
Screen Shot 2020-01-22 at 22 02 53

Has some space between the content?

@ccordoba12 ccordoba12 added this to the v0.3.0 milestone Jan 23, 2020
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456, I left a minor comment, and I also agree with @goanpeca on adding a bit of padding around the terminal to make it look better.

@steff456
Copy link
Member Author

With the padding, the terminal looks like this
image

@ccordoba12
Copy link
Member

It looks pretty nice!! Thanks @steff456!

@goanpeca?

@goanpeca
Copy link
Member

Beautiful 💘 !

For completeness could you post a dark theme version @steff456 ?

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @steff456!!

@ccordoba12 ccordoba12 merged commit f005c33 into spyder-ide:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some UI/UX improvements for 0.3.0
3 participants