Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Import sys for confpage #201

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

bnavigator
Copy link
Contributor

The confpage is missing an import and is thus not displayed in the spyder settings.

  File "/usr/lib/python3.8/site-packages/spyder/app/mainwindow.py", line 3175, in show_preferences
    widget = plugin._create_configwidget(dlg, self)
  File "/usr/lib/python3.8/site-packages/spyder/plugins/base.py", line 117, in _create_configwidget
    configwidget.initialize()
  File "/usr/lib/python3.8/site-packages/spyder/preferences/configdialog.py", line 72, in initialize
    self.load_from_conf()
  File "/usr/lib/python3.8/site-packages/spyder/preferences/configdialog.py", line 327, in load_from_conf
    checkbox.setChecked(self.get_option(option, default, section=sec))
TypeError: setChecked(self, bool): argument 1 has unexpected type 'str'
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/spyder/app/mainwindow.py", line 3175, in show_preferences
    widget = plugin._create_configwidget(dlg, self)
  File "/usr/lib/python3.8/site-packages/spyder/plugins/base.py", line 117, in _create_configwidget
    configwidget.initialize()
  File "/usr/lib/python3.8/site-packages/spyder/preferences/configdialog.py", line 72, in initialize
    self.load_from_conf()
  File "/usr/lib/python3.8/site-packages/spyder/preferences/configdialog.py", line 327, in load_from_conf
    checkbox.setChecked(self.get_option(option, default, section=sec))
TypeError: setChecked(self, bool): argument 1 has unexpected type 'str'
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/spyder/app/mainwindow.py", line 3175, in show_preferences
    widget = plugin._create_configwidget(dlg, self)
  File "/usr/lib/python3.8/site-packages/spyder/plugins/base.py", line 117, in _create_configwidget
    configwidget.initialize()
  File "/usr/lib/python3.8/site-packages/spyder/preferences/configdialog.py", line 71, in initialize
    self.setup_page()
  File "/usr/lib/python3.8/site-packages/spyder_terminal/confpage.py", line 50, in setup_page
    elif sys.platform.startswith('linux'):
NameError: name 'sys' is not defined

@goanpeca
Copy link
Member

@steff456 please review.

@steff456
Copy link
Member

Thanks @bnavigator !

@steff456 steff456 merged commit 2868d79 into spyder-ide:master Apr 24, 2020
@ccordoba12 ccordoba12 added this to the Sprint April milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants