Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Move Spyder-terminal plugin to Python 3 #215

Merged
merged 3 commits into from
Jun 25, 2020
Merged

PR: Move Spyder-terminal plugin to Python 3 #215

merged 3 commits into from
Jun 25, 2020

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Jun 24, 2020 •
edited
Loading

Remove compatibility with python 2

  • Update super() use
  • Remove the py3compat module
  • Update any code (and remove if necessary) that uses if PY2 etc...
  • Check division operator
  • Remove future imports
  • Check tests
  • Check for Py2 of Py3 codes

Fixes #212

@steff456 steff456 added this to the Sprint June milestone Jun 24, 2020
@steff456 steff456 requested a review from ccordoba12 June 24, 2020 20:12
@steff456 steff456 self-assigned this Jun 24, 2020
@ccordoba12 ccordoba12 changed the title Move Spyder-terminal plugin to Python 3 PR: Move Spyder-terminal plugin to Python 3 Jun 25, 2020
ccordoba12
ccordoba12 reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456 for this! The transition to Python 3 was way easier than I expected!

I only left a minor comment for you, otherwise looks good.

ccordoba12
ccordoba12 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456!

@ccordoba12 ccordoba12 merged commit 6aedf52 into spyder-ide:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@steff456 steff456

Labels
type:Techdebt
Projects
None yet
Milestone
Sprint June
Development

Successfully merging this pull request may close these issues.

Migrate this plugin to Python 3
2 participants
@steff456 @ccordoba12