IF statement with no braces and double catch turned into syntax error by auto-fixer

[PierreAntoineGuillaume]

When using cbf to clean up following sample code, it turns it

<?php

function testParse()
{
    if (true)
        try {
        } catch (\LogicException $e) {
        } catch (\Exception $e) {
        }
}

into

<?php

function testParse()
{
    if (true) {
        try {
        } catch (\LogicException $e) {
        }
    } catch (\Exception $e) {
    }
}

To reproduce
Steps to reproduce the behavior:

1. Create a file called test.php with the code sample above...
2. Run phpcbf test.php ...
3. now has a syntax error

$ vendor/bin/phpcbf test.php 

PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE                                                  FIXED  REMAINING
----------------------------------------------------------------------
test.php                                              5      0
----------------------------------------------------------------------
A TOTAL OF 5 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------

Time: 48ms; Memory: 10MB

Expected behavior
Either a fatal error and no code modification, or this code :

<?php

function testParse()
{
    if (true) {
        try {
        } catch (\LogicException $e) {
        } catch (\Exception $e) {
        }
    }
}

Versions (please complete the following information):

• OS: Ubuntu 20 (standard apt repo)
• PHP: 7.4
• PHPCS: 3.6.0
• Standard: PSR12

Here's a full version : https://github.com/GPierre-Antoine/phpcbf-bug

[jrfnl]

Confirmed.

A phpcs run yields the following issues:

-------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------------
 5 | ERROR | [x] Inline control structures are not allowed
   |       |     (Generic.ControlStructures.InlineControlStructure.NotAllowed)
 6 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
   |       |     (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
 7 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
   |       |     (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
 8 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
   |       |     (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
 9 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
   |       |     (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

The problem looks to be in the Generic.ControlStructures.InlineControlStructure sniff getting confused over the multi-catch.

If curly braces would have been used for the if (true) condition in the original code sample, PHPCS would not report any issues.

[jrfnl]

Just checked, same problem exists when using finally:

function testFinally()
{
    if (true)
        try {
        } catch (\LogicException $e) {
        } finally {
        }
}

[jrfnl]

PR #3347 should fix this. Testing appreciated.

[PierreAntoineGuillaume]

I tested it in my test repo, it works.

Thanks.

[jrfnl]

@GPierre-Antoine Thanks for testing!