Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on Illumos Issue #69

Closed
Smithx10 opened this issue Mar 7, 2019 · 2 comments · Fixed by #70
Closed

Building on Illumos Issue #69

Smithx10 opened this issue Mar 7, 2019 · 2 comments · Fixed by #70

Comments

@Smithx10
Copy link

Smithx10 commented Mar 7, 2019

Illumos doesn't have sys call.Flock. Could we please use syscall.FcntlFlock ?

# code.gitea.io/git/vendor/gopkg.in/src-d/go-billy.v4/osfs
../git/vendor/gopkg.in/src-d/go-billy.v4/osfs/os_posix.go:13:9: undefined: syscall.Flock
../git/vendor/gopkg.in/src-d/go-billy.v4/osfs/os_posix.go:13:41: undefined: syscall.LOCK_EX
../git/vendor/gopkg.in/src-d/go-billy.v4/osfs/os_posix.go:20:9: undefined: syscall.Flock
../git/vendor/gopkg.in/src-d/go-billy.v4/osfs/os_posix.go:20:41: undefined: syscall.LOCK_UN
mcuadros added a commit that referenced this issue Jun 30, 2019
Add support for solaris - fix #69
@Smithx10
Copy link
Author

@mcuadros In the next release of golang, Illumos will have its own build tag... So I believe taking advantage of the native flock system calls should be possible then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant