Add stork.js.map #391
Merged
Add stork.js.map #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, great. Looks like I should cut a 1.0.1.0 release with this fix (and potential others). |
srid
requested changes
Dec 5, 2022
|
Thanks for pointing that out! I'll try not to forget this next time. Do I also need to bump the version? I don't know what's the policy. |
srid
approved these changes
Dec 8, 2022
There is no policy so far, and no obligation on PR author to do these. I usually update changelog and increment version once the PR is close to be ready to be merged, assuming it will be a squash merge. But if you want to update them yourself, that's fine too. I haven't really settled on versioning policy yet, suggestions welcome. |
shivaraj-bh
pushed a commit
to shivaraj-bh/emanote
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Sridhar Ratnakumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source map file
stork.map.jsreferenced to in https://github.com/EmaApps/emanote/blob/a688aaeef0819071c1466f38d03bfa454ec9003f/default/_emanote-static/stork/stork.js#L2 is missing. This causes a source map error when viewing the site.Steps to reproduce the behavior:
I fix this by adding the
stork.js.mapfile downloaded from https://github.com/jameslittle230/stork/releases/tag/v1.5.0. The file wasn't there when stork was included in emanote; that's probably the reason it is missing.