generated from srid/ema-template
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include YAML frontmatter in the Stork index #398
Merged
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
38261b1
Include YAML frontmatter in the Stork index
jfpedroza 8ae237c
Read frontmatter setting from index.yaml
jfpedroza 134350f
Rename StorkInput to Config
jfpedroza 717c388
Derive FromJSON instance for Handling with generically
jfpedroza f5b77b2
Add docs
jfpedroza 0ee0418
Merge branch 'master' into jp/stork-frontmatter
srid 8387fe8
Version and changelog
srid 2aed502
Belongs in template
srid de8619c
refactor
srid e2c05f9
Add Default instance
srid 9a20d8a
group using where, to reduce top-level count (legibility)
srid 5367a2a
Re-order
srid 3ebb297
It makes sense to pass top-level 'Config' everywhere
srid 71efc1d
Use drop instead of replace for the JSON instance
jfpedroza 80dbe0f
Merge branch 'master' into jp/stork-frontmatter
srid efae3f4
Use deriving-aeson
srid 1fca169
Link docs in yaml
srid 695476d
edit docs
srid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
cabal-version: 2.4 | ||
name: emanote | ||
version: 1.0.1.5 | ||
version: 1.0.1.6 | ||
license: AGPL-3.0-only | ||
copyright: 2022 Sridhar Ratnakumar | ||
maintainer: [email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instance can be simplified using
https://hackage.haskell.org/package/aeson-casing-0.2.0.0/docs/Data-Aeson-Casing.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfpedroza Wanna take a stab at this?
Otherwise, I'll do the rest of the changes (including this one) tomorrow and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package works on
fieldLabelModifier
, notconstructorTagModifier
so I can't use the public functions. And even with the internal functions, they don't work on the formHandling_Ignore
, they expect camel case.The only thing useful is
applyFirst
that allows you to doIt's not worth to add the package for that function. I added it and changed
replace
withdrop
since it avoids the converting to text and back dance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
I actually should have suggested https://hackage.haskell.org/package/deriving-aeson because that's exactly what we need here.
cf. https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/deriving_via.html