-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficulties replicating with peers that are friends after doing a feed recovery #38
Comments
Strange. I have not seem EBT causing trouble like this in browser core. Browser core has been using EBT 8 for a while, but is driving the EBT a bit differently than ssb-ebt because it needs it only to kick in after partial replication has run for a feed. It would interesting to see if you can reproduce this to see if its the change in |
This would be simple and I don't see much downsides to it since we're going to anyway soon rewrite ssb-replicate, ssb-ebt, ssb-friends from ground up. |
I want to finish this issue once and for all, so I did some extensive testing. First I tried to reproduce this issue #38 and issue #33 using ssb-ebt Tape tests. Couldn't reproduce. Then I tried to reproduce it between Patchwork and Manyverse in the same LAN, using the typical reproduction steps, i.e.:
If Bob is using Patchwork 3.16.2, then Alice does not get her content back. That version had EBT disabled. If Bob uses Patchwork 3.17.1 or higher, then Alice successfully gets her content. That version had EBT enabled. I'm not sure what happens when Bob is not following Alice (but Alice follows Bob), because under ssb-conn scheduler logic, Bob would not initiate a connection with Alice. And neither would Alice (because she doesn't know she follows Bob). But I'm okay with that corner case, because it can be considered either a bug in ssb-conn scheduler or a user mistake (if you want your data back, make sure to trigger the connections). Anyway I don't think it's an issue with ssb-ebt. Sorry for the thorough message, but I'd like to give a definitive end to this issue. I want to stop using my hacky fork ssb-ebt-fork-staltz in Manyverse, and if people still encounter this issue, we can check:
And I don't believe there would be any other action necessary to take other than the 3 options mentioned above. |
Great debugging :) |
This issue in manyverse explains it properly: https://gitlab.com/staltz/manyverse/-/issues/1333#note_569151491
Quoting the relevant part:
Potentially related issue: #33
The text was updated successfully, but these errors were encountered: