This repository was archived by the owner on Oct 21, 2024. It is now read-only.
fix: python docker build architecture #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I totally forgot to add this back after bashing my head against the wall with buildx cross platform images. |
|
Thanks @mtmeyer! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you build a docker image for python lambdas on a machine with a different architecture to the target lambda, the lambda will fail to run.
This PR passes through the architecture the lambda uses to Pulumi's docker build.
Tested this locally and I can now run
sst deployfrom my M1 mac and it works on anx86_64lambda.Closes sst/sst#4115