Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository field to license #30

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Add repository field to license #30

merged 2 commits into from
Mar 17, 2024

Conversation

troppmann
Copy link
Contributor

Hey,
i realy like this tool. I also wanted to show the URL of the repository of each license.
The output includes now the URL as string of the repository.

@sstadick
Copy link
Owner

Thanks for the PR! I think I like the change, I just need to think about about how it might break existing installs / THIRDPARTY files and I haven't looked at the code in a bit.

If you had thoughts on that I'd be interested! I suppose a majore version bump could cover it.

@troppmann
Copy link
Contributor Author

There are 2 possible solutions i thought of.
First is to add the #[serde(default)] to the repository field this will parse old THIRDPARTY files without problems.
Second is to make the repository field an Optional<String>.
The first solution is more simple. The second solution should be used when an additional command flag is added to enable/disable the repository field.
I added #[serde(default)] for now, now it can parse the THIRDPARTY.yml file.

@sstadick
Copy link
Owner

I'm bumping the major version right now anyways, so I'm pulling this in.

@sstadick sstadick merged commit 98efdb7 into sstadick:main Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants