add validation of MLM output using classification:classes (fixes #48) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
approved these changes
Apr 22, 2024
|
@m-mohr Should we wait more for feedback or can it be merged as is? |
|
I think we can merge, but was just thinking that we should add a note in the Readme and a change log entry. |
|
@m-mohr Added in the latest commits. |
m-mohr
reviewed
May 13, 2024
Comment on lines
+15
to
18
| - `nodata` to `classification:classes` | ||
| - `nodata` to Class Object | ||
| - `percentage` to Class Object | ||
| - `count` to Class Object |
There was a problem hiding this comment.
Suggested change
| - `nodata` to `classification:classes` | |
| - `nodata` to Class Object | |
| - `percentage` to Class Object | |
| - `count` to Class Object | |
| - `nodata` to the Class Object | |
| - `nodata` to the Class Object | |
| - `percentage` to the Class Object | |
| - `count` to the Class Object |
Thanks. With regards to the README, I think it should be mentioned here: Otherwise it's not clear from the README directly that it can be used in MLM. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #48, adds the validation of
classification:classesnested under anmlm:outputdefinition.Adds an example demonstrating how it can be used.
For the moment, the MLM URI validation fails inside the npm checker as it is not yet published on stac-extensions (to be discussed in the next community meeting how to make that happen). The corresponding Item (https://github.com/crim-ca/dlm-extension/blob/v1.0.0/examples/item_raster_bands.json) is however validated in using the mapping in the repository https://github.com/crim-ca/dlm-extension/blob/v1.0.0/package.json#L8-L9.Uses the URI defined on https://crim-ca.github.io/mlm-extension/v1.1.0/schema.json
Looking for initial feedback in case some adjustments must be done before the MLM extension is published officially.
Fixes #48