feat: update geoarrow and duckdb #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gadomski
commented
Dec 6, 2024
•
gadomski
commented
- Closes Upgrade to duckdb v1.1 #385
gadomski
commented
Dec 24, 2024
kylebarron
reviewed
Dec 24, 2024
kylebarron
reviewed
Dec 24, 2024
kylebarron
reviewed
Dec 24, 2024
| if let Some((index, _)) = record_batch.schema().column_with_name("geometry") { | ||
| let geometry_column = record_batch.remove_column(index); | ||
| let binary_array: GenericByteArray<GenericBinaryType<i32>> = | ||
| arrow::array::downcast_array(&geometry_column); |
There was a problem hiding this comment.
Also it's cleaner to use geometry_column.as_binary<i32>() here: https://docs.rs/arrow/latest/arrow/array/cast/trait.AsArray.html#method.as_binary
There was a problem hiding this comment.
I used downcast_array because I wanted an owned array in the next line?
There was a problem hiding this comment.
IMO it's simpler/more canonical to use geometry_column.as_binary<i32>().clone(). All the data is under Arcs, so the clone() just increases some ref counts.
kylebarron
reviewed
Dec 24, 2024
This was referenced Dec 27, 2024
Merged
gadomski
added a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.