chore: better error reporting when getting

crates/api/CHANGELOG.md

@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 - kwargs to Python search build ([#591](https://github.com/stac-utils/stac-rs/pull/591))
 - `client::search` function ([#607](https://github.com/stac-utils/stac-rs/pull/607))
+- Better error reporting from `get` ([#670](https://github.com/stac-utils/stac-rs/pull/670))
 
 ## [0.7.0] - 2025-01-02
 

crates/core/src/error.rs

@@ -1,4 +1,4 @@
-use crate::Version;
+use crate::{Href, Version};
 use thiserror::Error;
 
 /// Error enum for crate-specific errors.
@@ -43,6 +43,16 @@ pub enum Error {
     #[error(transparent)]
     Geojson(#[from] Box<geojson::Error>),
 
+    /// An error occurred when getting an href.
+    #[error("error when getting href={href}: {message}")]
+    Get {
+        /// The href that we were trying to get.
+        href: Href,
+
+        /// The underling error message.
+        message: String,
+    },
+
     /// [std::io::Error]
     #[error(transparent)]
     Io(#[from] std::io::Error),

crates/core/src/format.rs

@@ -156,17 +156,30 @@ impl Format {
         V: Into<String>,
     {
         let href = href.into();
-        match href.realize() {
+        match href.clone().realize() {
             RealizedHref::Url(url) => {
                 use object_store::ObjectStore;
 
                 let (object_store, path) = parse_url_opts(&url, options)?;
-                let get_result = object_store.get(&path).await?;
+                tracing::debug!("getting {self} from {url} with object store");
+                let get_result = object_store.get(&path).await.map_err(|err| Error::Get {
+                    href,
+                    message: err.to_string(),
+                })?;
                 let mut value: T = self.from_bytes(get_result.bytes().await?)?;
                 *value.self_href_mut() = Some(Href::Url(url));
                 Ok(value)
             }
-            RealizedHref::PathBuf(path) => self.from_path(path),
+            RealizedHref::PathBuf(path) => {
+                tracing::debug!(
+                    "getting {self} from {} with the standard library",
+                    path.display()
+                );
+                self.from_path(path).map_err(|err| Error::Get {
+                    href,
+                    message: err.to_string(),
+                })
+            }
         }
     }