Skip to content

Commit

Permalink
Remove some redundant GL validation.
Browse files Browse the repository at this point in the history
ANGLE itself can manage most of WebGL validation. This makes the
transition to WebGL 2 validation easier because we won't need to write
new logic for all the new entry points.

To this effect this enables robust memory features in ANGLE, and also
updates the error set logic.

This contribution is funded by http://higharc.com/
  • Loading branch information
null77 authored and dhritzkiv committed Jan 27, 2025
1 parent 282ae88 commit 5731a50
Show file tree
Hide file tree
Showing 8 changed files with 184 additions and 1,274 deletions.
10 changes: 0 additions & 10 deletions src/javascript/extensions/angle-instanced-arrays.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,6 @@ class ANGLEInstancedArrays {
}

vertexAttribDivisorANGLE (index, divisor) {
const { ctx } = this
index |= 0
divisor |= 0
if (divisor < 0 ||
index < 0 || index >= ctx._vertexObjectState._attribs.length) {
ctx.setError(gl.INVALID_VALUE)
return
}
const attrib = ctx._vertexObjectState._attribs[index]
attrib._divisor = divisor
this._vertexAttribDivisorANGLE(index, divisor)
}
}
Expand Down
Loading

0 comments on commit 5731a50

Please sign in to comment.