Fix mock mining UTXO check to avoid unnecessary complaints #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Parikalp-Bhardwaj thanks for your patch, but i think you inadvertently committed a wrong file: the Cargo.toml is polluted with what it looks like an example config. In addition to this, it would be useful if you can craft an integration test for the patch as well as an updated CHANGELOG. Thanks again |
|
Thank you for reviewing @rdeioris. I made an incorrect commit in |
|
@Parikalp-Bhardwaj sorry i still see the Cargo.toml in the files list: https://github.com/stacks-network/stacks-core/pull/5845/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5841
This PR prevents the node from emitting misleading
No UTXOswarnings when running inmock_mining mode.Hi @diwakergupta ,I hoped this would work. Please let me know if there are any other suggestions or improvements.