-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use .rustfmt.toml for formatting options #5899
base: develop
Are you sure you want to change the base?
Conversation
We previously did this with the `cargo fmt-stacks` command because these config options were not supported in .rustfmt.toml, but they are now supported by the nightly build. Using this directly is better than the alias because we do not need to remember to run the alias.
Ah, right. This will also need a change in the rust format CI action... |
This may need a change in the actions repo. I will come back to it later. |
https://github.com/stacks-network/actions/blob/main/rustfmt/action.yml we created this composite because of the alias - i wonder if we can either fork the public workflow, or simply use the public one again |
Any way we can enforce "nightly" here? |
I don't see a way to force nightly for |
My latest commit puts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We previously did this with the
cargo fmt-stacks
command because these config options were not supported in .rustfmt.toml, but they are now supported by the nightly build. Using this directly is better than the alias because we do not need to remember to run the alias.