Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit to add a Modal about Linked notes #2891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diegorv
Copy link

@diegorv diegorv commented Mar 5, 2025

Hey team, this is just a suggestion, considering that I know it might not make any sense to you.

Since it's my first time interacting with the app's source code, please feel free to conduct the code review as needed or reject the pull request hehe ;)

Current Behavior: When viewing a note, in the note header, we currently display only 5 linked tags/notes. After that, it shows "and more X...".
CleanShot 2025-03-05 at 13 20 23

New Behavior: When viewing a note, in the note header, we display only the first 5 linked tags/notes as before. After that, we show a button labeled "(total count) more". When clicking the button, a modal opens displaying all the notes.
CleanShot 2025-03-05 at 13 20 43

CleanShot 2025-03-05 at 13 24 17

Questions:

  • Should I create a Component.test.tsx file to test each of these changes? I'm asking because I couldn't find specific tests for LinkedItemBubblesContainer, and I'm a bit confused about what I should do.
  • If you could clarify how you would like me to write the tests, along with any references or guidelines, that would be great!

I'm loving your application! ❤️ Congratulations on the great work! I even made sure to subscribe to the annual professional plan :)

@diegorv diegorv force-pushed the drv-add-linked-notes-modal branch from a05fc80 to 401cc7c Compare March 5, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant