-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transfer to L2): max amount #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-ziv)
src/hooks/useTransfer.js, line 74 at r1 (raw file):
handleError( progressOptions.error( new Error(`You are not allow to transfer more then ${maxAmount} ${symbol}`)
Consider adding a .
at the end.
Also, consider not letting the user choose a higher amount, to begin with. (maybe a slider with bounds [1, maxAmount]
)
Code quote:
You are not allow to transfer more then ${maxAmount} ${symbol}
src/hooks/useTransfer.js, line 74 at r1 (raw file): Previously, dan-starkware wrote…
Slider is no good with big numbers. For this we have the input field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text LGTM - I didn't review the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bbrandtom)
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Checklist
<type>(optional subject): <description>
, e.g:fix: minor typos in code
This change is