Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC endpoint adaptation #583

Closed

Conversation

YohanTz
Copy link
Contributor

@YohanTz YohanTz commented Apr 13, 2023

Motivation and Resolution

Commits from starknet-specs:

I can squash commits if preferred!

After starkware-libs/starknet-specs#84 is merged, we should be able to automatically generate the types of the starknet openrpc API but for now we have to modify them manually.

RPC version (if applicable)

0.2.1

Usage related changes

  • Introduce expected breaking changes in the starknet.js RPC Provider API

Development related changes

None

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes
  • Updated the docs (www)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for starknetjs ready!

Name Link
🔨 Latest commit f45b532
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/6462c479e145c3000730b6dd
😎 Deploy Preview https://deploy-preview-583--starknetjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@YohanTz YohanTz force-pushed the yohan/rpc-endpoint-adaptation branch from c50587e to eb095c5 Compare April 18, 2023 16:47
@tabaktoni
Copy link
Member

Hello @YohanTz, and thank you for contributing.
What is the status of RPC implementation, we will need to deal with this soon.

@YohanTz
Copy link
Contributor Author

YohanTz commented Apr 27, 2023

Hey @tabaktoni ! I paused this one as I was waiting for your new pathfinder node so I can test everything :) Is it set up now ?

@ivpavici
Copy link
Collaborator

I think Infura is running the pathfinder 0.5.3, so it should be able to test over there!

@YohanTz
Copy link
Contributor Author

YohanTz commented Apr 28, 2023

Ok perfect 👍

@ivpavici
Copy link
Collaborator

Related for local testing: 0xSpaceShard/starknet-devnet#467

@notV4l notV4l mentioned this pull request May 26, 2023
35 tasks
@ivpavici
Copy link
Collaborator

ivpavici commented Jun 12, 2023

superseded by #621

@ivpavici ivpavici closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants