-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel pending requests when didChange & et all appear. #6131
Comments
We have researched this with @Draggu. Conclusions: Cancellation is well-defined in the following Salsa RFC: https://murek.dev/salsa-book-0.16/rfcs/RFC0007-Opinionated-Cancelation.html
Running cancellation is not dependent on any work on The problem is, this RFC is not implemented in Salsa 0.16 😭 We will have to upgrade to Salsa 0.17; probably the fork maintained by Rust Analyzer: https://crates.io/crates/ra_ap_salsa |
Then any of the
textDocument/did*
requests come, we need to cancel all operations that are holding snapshots of theAnalysisDatabase
in order to unlock mutations to it.This task is spin off #5355
The text was updated successfully, but these errors were encountered: