-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BitNot operation. #3021
Added BitNot operation. #3021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 14 files at r1, all commit messages.
Reviewable status: 5 of 14 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-parser/src/lexer.rs
line 376 at r1 (raw file):
LT, Not, Tilde,
Our token are not named bang, dash, etc... They are baned Not, Minus, after the math operation. If we wanna be consistent, this should be BitNot or BitwiseNot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
crates/cairo-lang-parser/src/lexer.rs
line 376 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Our token are not named bang, dash, etc... They are baned Not, Minus, after the math operation. If we wanna be consistent, this should be BitNot or BitwiseNot.
i'm not really sure what is better in this case - do you really think BitNot
is clearer?
I dunno, but I'd rather be consistent |
f8dd784
to
9c0c399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 14 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
crates/cairo-lang-parser/src/lexer.rs
line 376 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
I dunno, but I'd rather be consistent
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
This change is