Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added diagnostics for if cond not bool. #3027

Merged
merged 1 commit into from
May 3, 2023
Merged

Added diagnostics for if cond not bool. #3027

merged 1 commit into from
May 3, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 3, 2023 •
edited by spapinistarkware
Loading

This change is Reviewable

@orizi orizi requested a review from spapinistarkware May 3, 2023 11:10
@orizi orizi enabled auto-merge May 3, 2023 11:10
@orizi orizi linked an issue May 3, 2023 that may be closed by this pull request
bug: Failed to specialize: enum_match<u8> #3020
Closed
spapinistarkware
spapinistarkware approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue May 3, 2023
Merged via the queue into main with commit 88b74c6 May 3, 2023
@orizi orizi deleted the orizi/added-if-cond-bool-diag branch May 9, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spapinistarkware spapinistarkware spapinistarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Failed to specialize: enum_match<u8>
2 participants
@orizi @spapinistarkware