Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added diagnostics for multiple definitions of fns in impls and traits. #3033

Merged
merged 1 commit into from
May 4, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 4, 2023

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware May 4, 2023 07:43
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-semantic/src/items/tests/trait line 559 at r1 (raw file):

//! > ==========================================================================

//! > trait/impl fn declared twice.

Add a new test instead of replacing.

@orizi orizi force-pushed the orizi/preventing-multi-def-in-impl-and-traits branch from b13a971 to 4eb44ec Compare May 4, 2023 07:48
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-semantic/src/items/tests/trait line 559 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Add a new test instead of replacing.

Done.

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi enabled auto-merge May 4, 2023 07:51
@orizi orizi added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit f3613b6 May 4, 2023
@orizi orizi deleted the orizi/preventing-multi-def-in-impl-and-traits branch May 9, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants