Added diagnostics for multiple definitions of fns in impls and traits. #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbens-starkware
requested changes
May 4, 2023
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-semantic/src/items/tests/trait line 559 at r1 (raw file):
//! > ========================================================================== //! > trait/impl fn declared twice.
Add a new test instead of replacing.
orizi
force-pushed
the
orizi/preventing-multi-def-in-impl-and-traits
branch
from
b13a971 to
4eb44ec
Compare
orizi
commented
May 4, 2023
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-semantic/src/items/tests/trait line 559 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Add a new test instead of replacing.
Done.
gilbens-starkware
approved these changes
May 4, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is