Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl Into<T,T> #3036

Merged
merged 3 commits into from
May 4, 2023
Merged

feat: impl Into<T,T> #3036

merged 3 commits into from
May 4, 2023

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented May 4, 2023 •
edited by spapinistarkware
Loading

This PR includes the following:

  • Implementation for Into<T,T> added into traits.cairo
  • Fix inferences issues caused by the implementation
  • Testing Into<Numeric, Numeric>

This change is Reviewable

spapinistarkware
spapinistarkware approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @greged93)

@spapinistarkware spapinistarkware added this pull request to the merge queue May 4, 2023
Merged via the queue into starkware-libs:main with commit 8a2d384 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spapinistarkware spapinistarkware spapinistarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greged93 @spapinistarkware