Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose run_tests in test runner #3126

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

karol-bisztyga
Copy link
Contributor

@karol-bisztyga karol-bisztyga commented May 11, 2023

Can we expose this function as a public one? We need this in protostar. Thanks.


This change is Reviewable

@karol-bisztyga
Copy link
Contributor Author

@mkaput 🙏

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, need approval from @orizi or @spapinistarkware

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @karol-bisztyga)

@mkaput mkaput requested review from spapinistarkware and orizi May 18, 2023 08:18
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@mkaput mkaput enabled auto-merge May 18, 2023 08:58
@mkaput
Copy link
Member

mkaput commented May 18, 2023

🤔
image

@mkaput mkaput added this pull request to the merge queue May 18, 2023
Merged via the queue into starkware-libs:main with commit 5170f13 May 18, 2023
milancermak pushed a commit to milancermak/cairo that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants