-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SpanSerde #3145
feat: SpanSerde #3145
Conversation
Bump. Could this still get merged into 1.1.0? I don't care if it's my PR or you do it internally, but people run into this issue all the time, so the sooner it's fixed the better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @milancermak)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @milancermak)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @milancermak)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Just fix the conflicts
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @milancermak)
Head branch was pushed to by a user without write access
21911c2
to
efe8e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts resolved. Moved the impl to array.cairo and slightly improved deserialize
.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @orizi and @spapinistarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @milancermak)
There's no Serde implementation for Spans. That means we can't for example emit events with Spans. This won't compile:
The error is:
This PR adds a
SpanSerde
that fixes the above error. I hope it's just as simple as I imagine it to be, please tell me if I'm missing something.This change is