-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added u256_div_mod_n #3190
Added u256_div_mod_n #3190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)
corelib/src/integer.cairo
line 1224 at r1 (raw file):
a: u256, b: NonZero<u256>, n: NonZero<u256> ) -> Option<u256> { let inv_b = math::inv_mod(b, n)?;
i think this should be in math
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/integer.cairo
line 1224 at r1 (raw file):
Previously, orizi wrote…
i think this should be in math
It's only for u256, as opposed to the others in math, currently.
If you still think it should be there, I can move it. LMK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)
corelib/src/integer.cairo
line 1224 at r1 (raw file):
Previously, yuvalsw wrote…
It's only for u256, as opposed to the others in math, currently.
If you still think it should be there, I can move it. LMK
I think it still is better (since if and when we'll make it work for others, it will be there anyway)
64f7b1f
to
07d813b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @yuvalsw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)
07d813b
to
9e6f4fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @orizi)
corelib/src/integer.cairo
line 1224 at r1 (raw file):
Previously, orizi wrote…
I think it still is better (since if and when we'll make it work for others, it will be there anyway)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @yuvalsw)
9e6f4fd
to
60e2885
Compare
This change is