Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue 3153. #3230

Merged
merged 1 commit into from
May 24, 2023
Merged

Fixing issue 3153. #3230

merged 1 commit into from
May 24, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 23, 2023

This change is Reviewable

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)


crates/cairo-lang-sierra-gas/src/gas_info.rs line 72 at r1 (raw file):

            let other_val = other.function_costs.get(key);
            assert!(
                match (self_val, other_val) {

Consider adding a wrapper type for the costs, and implement ParitalEq using sub_maps

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @spapinistarkware)


crates/cairo-lang-sierra-gas/src/gas_info.rs line 72 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Consider adding a wrapper type for the costs, and implement ParitalEq using sub_maps

this is spread all around, so would be a lot more changes - and i'm not sure this is actually required,
as this check fails just because it compares 2 different methods to calculate the same thing.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 02c7141 May 24, 2023
@orizi orizi deleted the orizi/fix-issue-5153 branch June 12, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: functionId comparison fails due to ordered hashmaps in cairo-lang-sierra-gas
2 participants