-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: derive serde for dispatchers #3241
feat: derive serde for dispatchers #3241
Conversation
689bbbb
to
7cd5a95
Compare
ed0fa69
to
777aacb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ftupas)
crates/cairo-lang-starknet/cairo_level_tests/contract_tests.cairo
line 17 at r2 (raw file):
#[abi] trait ITestContract {
if you are adding this only for the serde test - can you make this into a much simple abi?
Code quote:
#[abi]
trait ITestContract {
777aacb
to
93f2bec
Compare
Thanks for the review and feedback @orizi ! I've just updated this to a simpler abi, much less clutter thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ftupas)
93f2bec
to
ec587e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ftupas)
Hello there, this small pr does the following
This change is