Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derive serde for dispatchers #3241

Merged

Conversation

ftupas
Copy link
Contributor

@ftupas ftupas commented May 24, 2023

Hello there, this small pr does the following


This change is Reviewable

@ftupas ftupas force-pushed the feat/derive-serde-dispatchers branch 3 times, most recently from 689bbbb to 7cd5a95 Compare May 24, 2023 14:34
@ftupas ftupas force-pushed the feat/derive-serde-dispatchers branch 4 times, most recently from ed0fa69 to 777aacb Compare June 1, 2023 09:30
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ftupas)


crates/cairo-lang-starknet/cairo_level_tests/contract_tests.cairo line 17 at r2 (raw file):

#[abi]
trait ITestContract {

if you are adding this only for the serde test - can you make this into a much simple abi?

Code quote:

#[abi]
trait ITestContract {

@ftupas ftupas force-pushed the feat/derive-serde-dispatchers branch from 777aacb to 93f2bec Compare June 1, 2023 09:53
@ftupas
Copy link
Contributor Author

ftupas commented Jun 1, 2023

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ftupas)

crates/cairo-lang-starknet/cairo_level_tests/contract_tests.cairo line 17 at r2 (raw file):

#[abi]
trait ITestContract {

if you are adding this only for the serde test - can you make this into a much simple abi?

Code quote:

#[abi]
trait ITestContract {

Thanks for the review and feedback @orizi ! I've just updated this to a simpler abi, much less clutter thanks!

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ftupas)

@ftupas ftupas force-pushed the feat/derive-serde-dispatchers branch from 93f2bec to ec587e3 Compare June 1, 2023 10:10
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ftupas)

@spapinistarkware spapinistarkware added this pull request to the merge queue Jun 1, 2023
Merged via the queue into starkware-libs:main with commit 2b1d33b Jun 1, 2023
@ftupas ftupas deleted the feat/derive-serde-dispatchers branch June 1, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement Serde for dispatchers
3 participants