-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(corelib): Add missing impl for type conversions between U256 #3293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @lambda-0x)
corelib/src/integer.cairo
line 1572 at r1 (raw file):
} }
Wdyt about adding all the others
corelib/src/integer.cairo
line 1454 at r2 (raw file):
} // impls for (where X > 8):
I think it's better without these comments.
The impl signature is clear enough.
which other are missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lambda-0x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lambda-0x)
CI is failing due to this file having: cairo/tests/bug_samples/issue3211.cairo Lines 6 to 15 in d448693
Which causes there to be duplicate implementation error, what should i do with the duplicate impl in that test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be explicit when using this impl.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @lambda-0x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. refer to the specific impl by name
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @lambda-0x)
the problem is both have the same name, should rename the one used in test something else @spapinistarkware? they are essentially the same impl as well but in there its used to test some compiler branching issue, so removing it wouldn't make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to rename, it shadows the core one. u can rename if u want.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @lambda-0x)
This change is