Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move Serde impls from serde, near their types #3296

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

chirag-bgh
Copy link
Contributor

@chirag-bgh chirag-bgh commented Jun 2, 2023

Closes #2758


This change is Reviewable

@chirag-bgh chirag-bgh changed the title feat: Move Serde impls from serde, near their types (WIP) feat: Move Serde impls from serde, near their types Jun 2, 2023
@chirag-bgh chirag-bgh changed the title (WIP) feat: Move Serde impls from serde, near their types feat: Move Serde impls from serde, near their types Jun 5, 2023
@chirag-bgh chirag-bgh marked this pull request as ready for review June 5, 2023 12:43
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chirag-bgh)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chirag-bgh)

@spapinistarkware spapinistarkware added this pull request to the merge queue Jun 6, 2023
Merged via the queue into starkware-libs:main with commit 05f613a Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Move Serde impls from serde, near their types
3 participants