Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cairo-vm version. #3334

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Update cairo-vm version. #3334

merged 1 commit into from
Jun 8, 2023

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jun 8, 2023

This change is Reviewable

Copy link
Contributor

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi and @spapinistarkware)

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi and @spapinistarkware)

Copy link
Contributor

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @orizi, and @spapinistarkware)

a discussion (no related file):
wonder why you aren't getting my errors...
probably because you didn't run cargo update, but I'm not sure if it's required.
@spapinistarkware / @orizi ?


Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @orizi, and @spapinistarkware)

@alonh5 alonh5 added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit e71724e Jun 8, 2023
@orizi orizi deleted the alonh/update_cairo_vm_version branch June 28, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants