-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference queues #3347
Inference queues #3347
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
0356a16
to
d94b2eb
Compare
1c24518
to
fe7e294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 22 of 33 files at r1, 5 of 5 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @spapinistarkware)
crates/cairo-lang-semantic/src/expr/inference.rs
line 115 at r3 (raw file):
ConstInferenceNotSupported, // TODO: These are only used for external interface.
assign
Code quote:
// TODO: These are only used for external interface.
crates/cairo-lang-semantic/src/expr/inference.rs
line 167 at r3 (raw file):
InferenceError::Failed(diagnostic_added) => *diagnostic_added, // TODO(spapini): Better save the DiagnosticAdded on the variable. // InferenceError::AlreadyReported => skip_diagnostic(),
?
Code quote:
// InferenceError::AlreadyReported => skip_diagnostic(),
crates/cairo-lang-semantic/src/expr/inference.rs
line 488 at r3 (raw file):
mut lookup_context: ImplLookupContext, ) -> InferenceResult<SolutionSet<(CanonicalImpl, CanonicalMapping)>> { // TODO: This is done twice.
assign
Code quote:
/ TODO: This is done twice.
crates/cairo-lang-semantic/src/expr/inference/canonic.rs
line 207 at r3 (raw file):
} // Mapper rewriter. Maps variables according to a given [VarMapping].
Suggestion:
/// Mapper rewriter. Maps variables according to a given [VarMapping].
crates/cairo-lang-semantic/src/expr/inference/conform.rs
line 14 at r3 (raw file):
}; pub trait InferenceConform {
doc
crates/cairo-lang-semantic/src/expr/inference/infers.rs
line 18 at r3 (raw file):
}; pub trait InferenceEmbeddings {
doc
crates/cairo-lang-semantic/src/expr/test_data/method
line 109 at r3 (raw file):
^***********************^ error: Candidate impl test::AnotherOptionTraitImpl::<core::felt252> has a free variable
i don't think this is understandable - can you make this clearer?
Code quote:
a free variable
crates/cairo-lang-semantic/src/items/imp.rs
line 1113 at r3 (raw file):
// Check fully resolved. if let Some((stable_ptr, inference_err)) = resolver.inference().finalize() { // TODO: Better location.
assign
crates/cairo-lang-semantic/src/items/trt.rs
line 227 at r3 (raw file):
// Check fully resolved. if let Some((stable_ptr, inference_err)) = resolver.inference().finalize() { // TODO: Better location.
doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @orizi)
crates/cairo-lang-semantic/src/expr/inference.rs
line 115 at r3 (raw file):
Previously, orizi wrote…
assign
Done.
crates/cairo-lang-semantic/src/expr/inference.rs
line 167 at r3 (raw file):
Previously, orizi wrote…
?
Done.
crates/cairo-lang-semantic/src/expr/inference.rs
line 488 at r3 (raw file):
Previously, orizi wrote…
assign
Done.
crates/cairo-lang-semantic/src/expr/inference/canonic.rs
line 207 at r3 (raw file):
} // Mapper rewriter. Maps variables according to a given [VarMapping].
Done.
crates/cairo-lang-semantic/src/expr/inference/conform.rs
line 14 at r3 (raw file):
Previously, orizi wrote…
doc
Done.
crates/cairo-lang-semantic/src/expr/inference/infers.rs
line 18 at r3 (raw file):
Previously, orizi wrote…
doc
Done.
crates/cairo-lang-semantic/src/expr/test_data/method
line 109 at r3 (raw file):
Previously, orizi wrote…
i don't think this is understandable - can you make this clearer?
Done.
crates/cairo-lang-semantic/src/items/imp.rs
line 1113 at r3 (raw file):
Previously, orizi wrote…
assign
Done.
crates/cairo-lang-semantic/src/items/trt.rs
line 227 at r3 (raw file):
Previously, orizi wrote…
doc
Done.
212a2c1
to
1f6df34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r4.
Reviewable status: 30 of 34 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
crates/cairo-lang-semantic/src/expr/inference/solver.rs
line 51 at r4 (raw file):
Ambiguity::FreeVariable { impl_id, var: _ } => { format!( "Candidate impl {:?} has a free variable with no constraints.",
Suggestion:
Candidate impl {:?} has a generic param with no constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r4, 1 of 4 files at r5.
Reviewable status: 31 of 34 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r5.
Reviewable status: 33 of 34 files reviewed, all discussions resolved (waiting on @spapinistarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
This change is