-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed bytes31 casts to use libfunc upcast. #4098
Changed bytes31 casts to use libfunc upcast. #4098
Conversation
960d35f
to
dd1d167
Compare
dd1d167
to
ee6b2c0
Compare
16a9553
to
bac1fdf
Compare
ee6b2c0
to
3720f75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @orizi and @yuvalsw)
tests/e2e_test_data/libfuncs/bytes31
line 155 at r2 (raw file):
//! > ========================================================================== //! > upcast<u8, bytes31>
I think one is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @yuvalsw)
360fc87
to
f0c2ddf
Compare
3720f75
to
a52695a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @liorgold2 and @yuvalsw)
tests/e2e_test_data/libfuncs/bytes31
line 155 at r2 (raw file):
Previously, liorgold2 wrote…
I think one is enough.
Done.
f0c2ddf
to
58c40d6
Compare
a52695a
to
c0e8bb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)
58c40d6
to
d9983bb
Compare
c054824
to
aa8c7c5
Compare
38995da
to
97e3500
Compare
aa8c7c5
to
d94812e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)
d94812e
to
70c3af4
Compare
97e3500
to
45ad990
Compare
70c3af4
to
5145f3c
Compare
45ad990
to
18d46f1
Compare
5145f3c
to
00532eb
Compare
18d46f1
to
6ed4910
Compare
211cc01
to
5e04680
Compare
39b81d4
to
bcfa44c
Compare
5e04680
to
0203088
Compare
Changes the `upcast` libfunc which is already allowed. #should_audit commit-id:3e5dcf40
0203088
to
d876f5d
Compare
Changes the
upcast
libfunc which is already allowed. #should_auditThis change is