Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed bytes31 casts to use libfunc upcast. #4098

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Sep 20, 2023

Changes the upcast libfunc which is already allowed. #should_audit


This change is Reviewable

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from 960d35f to dd1d167 Compare September 20, 2023 07:46
@orizi orizi requested review from yuvalsw and liorgold2 September 20, 2023 07:46
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from dd1d167 to ee6b2c0 Compare September 27, 2023 05:23
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from 16a9553 to bac1fdf Compare September 27, 2023 05:23
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from ee6b2c0 to 3720f75 Compare September 27, 2023 06:58
Copy link
Collaborator

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @orizi and @yuvalsw)


tests/e2e_test_data/libfuncs/bytes31 line 155 at r2 (raw file):

//! > ==========================================================================

//! > upcast<u8, bytes31>

I think one is enough.

Copy link
Collaborator

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @yuvalsw)

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from 360fc87 to f0c2ddf Compare October 1, 2023 13:18
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from 3720f75 to a52695a Compare October 1, 2023 13:18
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @liorgold2 and @yuvalsw)


tests/e2e_test_data/libfuncs/bytes31 line 155 at r2 (raw file):

Previously, liorgold2 wrote…

I think one is enough.

Done.

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from f0c2ddf to 58c40d6 Compare October 1, 2023 13:31
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from a52695a to c0e8bb3 Compare October 1, 2023 13:31
Copy link
Collaborator

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from 58c40d6 to d9983bb Compare October 2, 2023 10:26
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch 2 times, most recently from c054824 to aa8c7c5 Compare October 2, 2023 11:40
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch 2 times, most recently from 38995da to 97e3500 Compare October 2, 2023 11:56
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from aa8c7c5 to d94812e Compare October 2, 2023 11:56
Copy link
Collaborator

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from d94812e to 70c3af4 Compare October 2, 2023 16:04
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from 97e3500 to 45ad990 Compare October 2, 2023 16:04
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from 70c3af4 to 5145f3c Compare October 3, 2023 07:54
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from 45ad990 to 18d46f1 Compare October 3, 2023 07:54
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from 5145f3c to 00532eb Compare October 4, 2023 14:24
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch from 18d46f1 to 6ed4910 Compare October 4, 2023 14:24
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch 2 times, most recently from 211cc01 to 5e04680 Compare October 10, 2023 08:13
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/c56d4b74 branch 2 times, most recently from 39b81d4 to bcfa44c Compare October 10, 2023 08:51
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from 5e04680 to 0203088 Compare October 10, 2023 08:51
Changes the `upcast` libfunc which is already allowed. #should_audit

commit-id:3e5dcf40
@orizi orizi changed the base branch from pr/orizi/orizi/signed-ints/c56d4b74 to sierra-minor-update October 10, 2023 09:14
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/3e5dcf40 branch from 0203088 to d876f5d Compare October 10, 2023 09:14
@orizi orizi added this pull request to the merge queue Oct 10, 2023
Merged via the queue into sierra-minor-update with commit dea220f Oct 10, 2023
@orizi orizi deleted the pr/orizi/orizi/signed-ints/3e5dcf40 branch October 10, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants