Fix stack tracking bug. #4263
Fix stack tracking bug. #4263
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-sierra-generator/src/store_variables/state.rs line 121 at r1 (raw file):
match &arg_states[*param_idx] { VarState::TempVar { .. } => { if matches!(
the original code is here:
Code quote:
if matches!(
ilyalesokhin-starkware
force-pushed
the
ilya/stack_tracking
branch
from
f61e967 to
f2054c0
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-sierra-generator/src/store_variables/state.rs line 121 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
the original code is here:
add some documentation here as to why you are doing this.
ilyalesokhin-starkware
force-pushed
the
ilya/stack_tracking
branch
from
f2054c0 to
cd13878
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
ilyalesokhin-starkware
force-pushed
the
ilya/stack_tracking
branch
from
cd13878 to
3ece48d
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
This change is