Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin suites. #4349

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Added plugin suites. #4349

merged 1 commit into from
Nov 5, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 2, 2023

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

@orizi orizi changed the base branch from pr/orizi/inline-macros/f49b97e1 to main November 2, 2023 16:23
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch from 7ec3a87 to 766a2cf Compare November 2, 2023 16:23
@orizi orizi changed the base branch from main to pr/orizi/inline-macros/f49b97e1 November 2, 2023 16:23
@orizi orizi requested review from mkaput and yuvalsw November 2, 2023 16:24
@orizi orizi changed the base branch from pr/orizi/inline-macros/f49b97e1 to main November 2, 2023 16:32
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch from 766a2cf to 7573418 Compare November 2, 2023 16:33
@orizi orizi changed the title Added plugin suites. Remove redundent diagnostics for inline macros. Nov 2, 2023
@orizi orizi changed the title Remove redundent diagnostics for inline macros. Added plugin suites. Nov 2, 2023
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch from 7573418 to bf9b007 Compare November 2, 2023 16:45
@orizi orizi changed the base branch from main to pr/orizi/inline-macros/f49b97e1 November 2, 2023 16:45
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch 2 times, most recently from 0cf1793 to 85ee01b Compare November 2, 2023 17:18
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch from 85ee01b to 87b7ad5 Compare November 5, 2023 09:10
@orizi orizi force-pushed the pr/orizi/inline-macros/f49b97e1 branch from 87e5942 to 46fc469 Compare November 5, 2023 09:10
@orizi orizi changed the base branch from pr/orizi/inline-macros/f49b97e1 to main November 5, 2023 10:05
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch from 87b7ad5 to 2ceb8c0 Compare November 5, 2023 10:05
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput, @orizi, and @yuvalsw)


crates/cairo-lang-plugins/src/lib.rs line 13 at r1 (raw file):

mod test;

/// Gets the base plugin suite to load into the Cairo compiler.

Mention that this doesn't include the inline plugins.

Code quote:

/// Gets the base plugin suite to load into the Cairo compiler.

commit-id:d6515d5e
@orizi orizi force-pushed the pr/orizi/inline-macros/d6515d5e branch from 2ceb8c0 to a2a0a22 Compare November 5, 2023 11:17
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput and @yuvalsw)

@orizi orizi added this pull request to the merge queue Nov 5, 2023
Merged via the queue into main with commit 42a46ea Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants