-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plugin suites. #4349
Added plugin suites. #4349
Conversation
7ec3a87
to
766a2cf
Compare
766a2cf
to
7573418
Compare
7573418
to
bf9b007
Compare
0cf1793
to
85ee01b
Compare
85ee01b
to
87b7ad5
Compare
87e5942
to
46fc469
Compare
87b7ad5
to
2ceb8c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput, @orizi, and @yuvalsw)
crates/cairo-lang-plugins/src/lib.rs
line 13 at r1 (raw file):
mod test; /// Gets the base plugin suite to load into the Cairo compiler.
Mention that this doesn't include the inline plugins.
Code quote:
/// Gets the base plugin suite to load into the Cairo compiler.
commit-id:d6515d5e
2ceb8c0
to
a2a0a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mkaput and @yuvalsw)
Stack:
This change is