-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more data for missing method diagnostic. #4405
Conversation
3288761
to
d29844c
Compare
f928dba
to
407eb3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 8 files at r1, 2 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-semantic/src/diagnostic.rs
line 536 at r3 (raw file):
err.format(db) )) .join("\n")
Consider adding an InferenceErrors
type which will implement Display
to avoid the map
duplication below.
Code quote:
inference_errors
.iter()
.map(|(trait_member, err)| format!(
"Candidate `{}` inference failed with: {}",
trait_member.full_path(db.upcast()),
err.format(db)
))
.join("\n")
407eb3c
to
9643be5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-semantic/src/diagnostic.rs
line 536 at r3 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Consider adding an
InferenceErrors
type which will implementDisplay
to avoid themap
duplication below.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 8 files at r1, 2 of 5 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
This change is