Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute parsing with only an identifier after. #4407

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

gilbens-starkware
Copy link
Contributor

@gilbens-starkware gilbens-starkware commented Nov 15, 2023

This change is Reviewable

@gilbens-starkware gilbens-starkware force-pushed the gil/attribute_parse_identifier branch from fb55ebd to 74de763 Compare November 15, 2023 09:49
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-parser/src/parser.rs line 2245 at r1 (raw file):

    // Skips a taken node, from the current offset adjusted to include the current token. Use it if the skipped node was the last to be taken.

make actual doc.

Copy link
Contributor Author

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-parser/src/parser.rs line 2245 at r1 (raw file):

Previously, orizi wrote…

make actual doc.

Done.

@gilbens-starkware gilbens-starkware force-pushed the gil/attribute_parse_identifier branch from 74de763 to 59f8a3c Compare November 15, 2023 11:10
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@gilbens-starkware gilbens-starkware added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 9f46ab4 Nov 15, 2023
@orizi orizi deleted the gil/attribute_parse_identifier branch November 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants