Fix attribute parsing with only an identifier after. #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbens-starkware
force-pushed
the
gil/attribute_parse_identifier
branch
from
fb55ebd to
74de763
Compare
orizi
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-parser/src/parser.rs line 2245 at r1 (raw file):
// Skips a taken node, from the current offset adjusted to include the current token. Use it if the skipped node was the last to be taken.
make actual doc.
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-parser/src/parser.rs line 2245 at r1 (raw file):
Previously, orizi wrote…
make actual doc.
Done.
gilbens-starkware
force-pushed
the
gil/attribute_parse_identifier
branch
from
74de763 to
59f8a3c
Compare
orizi
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
orizi
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is