Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made auto-available traits be prelude based. #4410

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 15, 2023

This change is Reviewable

@orizi orizi force-pushed the orizi/made-available-traits-prelude-based branch 2 times, most recently from c06c181 to abc4f84 Compare November 16, 2023 05:31
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-semantic/src/resolve/mod.rs line 772 at r1 (raw file):

        }
        // Last resort, use the `prelude` module as the base module.
        // Last resort, use the `prelude` module as the base module.

Remove

Code quote:

// Last resort, use the `prelude` module as the base module.

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-semantic/src/resolve/mod.rs line 772 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Remove

Done.

@orizi orizi force-pushed the orizi/made-available-traits-prelude-based branch from abc4f84 to f00420a Compare November 16, 2023 07:47
@orizi orizi enabled auto-merge November 16, 2023 07:47
@orizi orizi added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 0d319e9 Nov 16, 2023
@orizi orizi deleted the orizi/made-available-traits-prelude-based branch November 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants