Added assert_ne! test macro #4424
Conversation
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, all commit messages.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @clint419)
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 19 at r1 (raw file):
fn generate_code( &self, db: &dyn SyntaxGroup,
and remove the later explicit call.
Suggestion:
trait CompareAssertionPlugin: NamedPlugin {
const OPERATOR: &'static str;
}
impl NamedPlugin for CompareAssertionPlugin {
fn generate_code(
&self,
db: &dyn SyntaxGroup,crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 101 at r1 (raw file):
); "#, },
Suggestion:
let operator = Self::OPERATOR;
builder.add_modified(RewriteNode::interpolate_patched(
&formatdoc! {
r#"
{{
{maybe_assign_lhs}
{maybe_assign_rhs}
if !(@$lhs_value$ {operator} @$rhs_value$) {{
let mut {f}: core::fmt::Formatter = core::traits::Default::default();
core::result::ResultTrait::<(), core::fmt::Error>::unwrap(
write!({f}, "assertion `{lhs_escaped} {operator} {rhs_escaped}` failed")
);
"#,
},
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @orizi)
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 19 at r1 (raw file):
and remove the later explicit call.
The CompareAssertionPlugin is a trait that does not implement the NamedPlugin
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 101 at r1 (raw file):
); "#, },
- This is a good suggestion
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @clint419)
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 19 at r1 (raw file):
Previously, clint419 (Clint) wrote…
and remove the later explicit call.
The CompareAssertionPlugin is a trait that does not implement the NamedPlugin
instead:
trait CompareAssertionPlugin {
const NAME: &'static str;
const OPERATOR: &'static str;
}
impl<T: CompareAssertionPlugin> NamedPlugin for T {
...
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @orizi)
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 19 at r1 (raw file):
Previously, orizi wrote…
instead:
trait CompareAssertionPlugin { const NAME: &'static str; const OPERATOR: &'static str; } impl<T: CompareAssertionPlugin> NamedPlugin for T { ...
The code violates orphan rules
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 5 unresolved discussions (waiting on @clint419)
a discussion (no related file):
add test to corelib/src/test/testing_test.cairo
crates/cairo-lang-test-runner/test_data/lib.cairo line 54 at r2 (raw file):
let mut contract1 = IBalanceDispatcher { contract_address: address1 }; assert_eq!(contract0.get(), 100);
revert.
scripts/starknet_test.sh line 6 at r2 (raw file):
crates/cairo-lang-starknet/cairo_level_tests/ --starknet && \ cargo run --bin cairo-test -- \ crates/cairo-lang-test-runner/test_data/ --starknet
revert.
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 19 at r1 (raw file):
Previously, clint419 (Clint) wrote…
The code violates orphan rules
you can solve it in the standard way of solving it by using a wrapper.
If you don't want to do this - just make the generate_code a function with generic arg - you get nothing from this trait.
clint419
force-pushed
the
add_assert_ne_macro
branch
from
05997e9 to
ebeb425
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 5 unresolved discussions (waiting on @orizi)
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 19 at r1 (raw file):
you can solve it in the standard way of solving it by using a wrapper.
Yes. can i use macro complete?
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 5 unresolved discussions (waiting on @orizi)
crates/cairo-lang-test-runner/test_data/lib.cairo line 54 at r2 (raw file):
Previously, orizi wrote…
revert.
Done.
scripts/starknet_test.sh line 6 at r2 (raw file):
Previously, orizi wrote…
revert.
Done.
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @clint419)
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 13 at r3 (raw file):
use indoc::formatdoc; trait CompareAssertionPlugin: NamedPlugin {
Doc
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @clint419)
clint419
force-pushed
the
add_assert_ne_macro
branch
from
fde0e81 to
d139f41
Compare
There was a problem hiding this comment.
Reviewable status: 5 of 7 files reviewed, 2 unresolved discussions (waiting on @orizi)
a discussion (no related file):
Previously, orizi wrote…
add test to
corelib/src/test/testing_test.cairo
Done.
crates/cairo-lang-test-plugin/src/inline_macros/assert.rs line 13 at r3 (raw file):
Previously, orizi wrote…
Doc
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @clint419)
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
@gilbens-starkware for 2nd eye.
There was a problem hiding this comment.
Reviewed 2 of 6 files at r1, 1 of 3 files at r3, 1 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @clint419)
vscode-cairo/snippets/cairo.json line 226 at r4 (raw file):
"prefix": "assert_ne!", "body": ["assert_ne!($1, $2);"], "description": "Creates an simple test"
Suggestion:
Creates an inline macro for asserting non-equality.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @clint419)
vscode-cairo/snippets/cairo.json line 226 at r4 (raw file):
"prefix": "assert_ne!", "body": ["assert_ne!($1, $2);"], "description": "Creates an simple test"
Maybe
Creates an assert_ne! macro.
As it should be short description.
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)
vscode-cairo/snippets/cairo.json line 226 at r4 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Maybe
Creates an assert_ne! macro.
As it should be short description.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
clint419
force-pushed
the
add_assert_ne_macro
branch
from
036842b to
37de835
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
@orizi Hi, i added an
assert_ne!macro, you see if the pr is necessary, thank youThis change is