Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding snapshot forwarding. #4430

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Adding snapshot forwarding. #4430

merged 1 commit into from
Nov 20, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 20, 2023

Removing not yet audited libfunc nullable_match_snapshot using this feature.


This change is Reviewable

Removing not yet audited libfunc nullable_match_snapshot using this
feature.
@orizi orizi linked an issue Nov 20, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/box.cairo line 21 at r1 (raw file):

        unbox(self)
    }
    fn as_snapshot(self: @Box<T>) -> Box<@T> nopanic {

Suggestion:

#[inline(always)]
fn as_snapshot(self: @Box<T>) -> Box<@T> nopanic {

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit 5684a14 Nov 20, 2023
@orizi orizi deleted the orizi/snapshot-forwarding branch November 22, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: unbox_snapshot to unbox Box<T> into @T
2 participants