Depraction warning for external(v0) on impls.

[orizi]

Stack:

• Added semantic analyzer plugins support. #4480
• Depraction warning for external(v0) on impls. #4470 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[gilbens-starkware]

Reviewed 14 of 16 files at r1, all commit messages.
Reviewable status: 14 of 16 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-starknet/src/plugin/utils.rs line 218 at r1 (raw file):

    if let Some(deprecated) = deprecated() {
        diagnostics.push(PluginDiagnostic::warning(attr.stable_ptr().untyped(), deprecated));
    }

It'll raise this warning for any attr_name attribute, in our case, also for #[external(any_text_in_here)], which is not deprecated as it haven't been supported. Maybe validate_v0 should return a bool and the warning should be raised according to it.

Code quote:

    if let Some(deprecated) = deprecated() {
        diagnostics.push(PluginDiagnostic::warning(attr.stable_ptr().untyped(), deprecated));
    }

[orizi]

Reviewable status: 14 of 16 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

crates/cairo-lang-starknet/src/plugin/utils.rs line 218 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

It'll raise this warning for any attr_name attribute, in our case, also for #[external(any_text_in_here)], which is not deprecated as it haven't been supported. Maybe validate_v0 should return a bool and the warning should be raised according to it.

the external is what is deprecated - so i'm fine with this.

[gilbens-starkware]

Reviewed 2 of 16 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)