Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Not a trait. diagnostic if a diagnostic was already reported. #4477

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

ilyalesokhin-starkware
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware commented Nov 26, 2023

This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-semantic/src/expr/test_data/generics line 556 at r1 (raw file):

 --> lib.cairo:4:19
impl MyImpl<T> of MyTrait<T, T> {
                  ^***********^

I think we should remove this error.

Code quote:

error: Not a trait.
 --> lib.cairo:4:19
impl MyImpl<T> of MyTrait<T, T> {
                  ^***********^

@ilyalesokhin-starkware ilyalesokhin-starkware changed the title Add test case to diagnostics. Avoid Not a trait. diagnostic if a diagnostic was already reported. Nov 26, 2023
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware ilyalesokhin-starkware changed the title Avoid Not a trait. diagnostic if a diagnostic was already reported. Avoid Not a trait. diagnostic if a diagnostic was already reported. Nov 26, 2023
@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Nov 26, 2023
Merged via the queue into main with commit 21fb120 Nov 26, 2023
@orizi orizi deleted the ilya/diag_test branch November 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants